Network should not be forced available #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap active_internet_connection call in an if statement so the return code is consumed by the conditional rather than causing the set_up_before_script hook to fail when BASHUNIT_NO_NETWORK=true or when no network tools are available. Fixes #582
JesusValeraDev
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Fixes #582 - The install test was incorrectly using the return value of
bashunit::env::active_internet_connectionby capturing it with$?after assignment, which doesn't work as expected in bash. This caused network availability to be forced/assumed rather than properly detected.🔖 Changes
install_test.shto use proper if/else conditional instead of relying on$?after function callACTIVE_INTERNETto 0 (true) or 1 (false) based on actual network availability✅ To-do list
CHANGELOG.mdto reflect the new feature or fix